Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing field name in core_0140_base6 rule. #605

Merged
merged 2 commits into from
Aug 31, 2020

Conversation

juli4n
Copy link
Contributor

@juli4n juli4n commented Aug 25, 2020

Add missing string format parameter. The error is showing as:

"Field %q mentions base64 encoding in comments, so it should probably be type bytes, not string"

Add missing string format parameter. The error is showing as:

"Field %q mentions base64 encoding in comments, so it should probably be type `bytes`, not `string`"
@juli4n juli4n requested a review from a team August 25, 2020 00:34
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 25, 2020
Copy link
Contributor

@lukesneeringer lukesneeringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whups, thanks!

@lukesneeringer lukesneeringer merged commit 93becf4 into googleapis:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants