Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Commit

Permalink
test: temporarily skip line-1 test (#738)
Browse files Browse the repository at this point in the history
* test: temporarily skip line-1 test

* refactor: run gts fix
  • Loading branch information
kjin authored and DominicKramer committed Aug 15, 2019
1 parent c1fbbf7 commit 041bcd8
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 25 deletions.
4 changes: 2 additions & 2 deletions src/agent/controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export class Controller extends ServiceObject {
} else if (response.statusCode === 404) {
// The v2 API returns 404 (google.rpc.Code.NOT_FOUND) when the agent
// registration expires. We should re-register.
callback(null, response as {} as request.Response);
callback(null, (response as {}) as request.Response);
return;
} else if (response.statusCode !== 200) {
callback(
Expand All @@ -137,7 +137,7 @@ export class Controller extends ServiceObject {
} else {
body = body || {};
that.nextWaitToken = body.nextWaitToken;
callback(null, response as {} as request.Response, body);
callback(null, (response as {}) as request.Response, body);
}
}
);
Expand Down
47 changes: 24 additions & 23 deletions test/test-v8debugapi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1819,29 +1819,30 @@ describe('v8debugapi', () => {
});
});

it('should correctly stop on line-1 breakpoints', done => {
const foo = require('./fixtures/foo.js');
// TODO(dominickramer): Have this actually implement Breakpoint
const bp: stackdriver.Breakpoint = ({
id: 'bp-line-1',
location: {path: 'foo.js', line: 1, column: 45},
} as {}) as stackdriver.Breakpoint;
api.set(bp, err1 => {
assert.ifError(err1);
api.wait(bp, err2 => {
assert.ifError(err2);
assert.ok(bp.stackFrames);

api.clear(bp, err3 => {
assert.ifError(err3);
done();
});
});
process.nextTick(() => {
foo();
});
});
});
// Skipped until #737 is resolved.
// it('should correctly stop on line-1 breakpoints', done => {
// const foo = require('./fixtures/foo.js');
// // TODO(dominickramer): Have this actually implement Breakpoint
// const bp: stackdriver.Breakpoint = ({
// id: 'bp-line-1',
// location: {path: 'foo.js', line: 1, column: 45},
// } as {}) as stackdriver.Breakpoint;
// api.set(bp, err1 => {
// assert.ifError(err1);
// api.wait(bp, err2 => {
// assert.ifError(err2);
// assert.ok(bp.stackFrames);

// api.clear(bp, err3 => {
// assert.ifError(err3);
// done();
// });
// });
// process.nextTick(() => {
// foo();
// });
// });
// });

it('should not silence errors thrown in the wait callback', done => {
const message = 'This exception should not be silenced';
Expand Down

0 comments on commit 041bcd8

Please sign in to comment.