fix: use well-formatted URLs when setting breakpoints

googleapis · Oct 3, 2018 · 1e6bd43 · 1e6bd43
1 parent 62b5bea
commit 1e6bd43
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/agent/state/inspector-state.ts b/src/agent/state/inspector-state.ts
@@ -276,7 +276,15 @@ class StateResolver {
     if (this.scriptmapper[scriptId].url === undefined) {
       return '';
     }
-    return this.scriptmapper[scriptId].url;
+    const scriptUrl = this.scriptmapper[scriptId].url;
+    if (scriptUrl.startsWith('file://')) {
+      // In Node 11+, non-internal files are formatted as URLs, so get just the
+      // path.
+      return scriptUrl.slice('file://'.length);
+    } else {
+      // Internal files should be returned as is.
+      return scriptUrl;
+    }
   }
 
   resolveRelativePath_(frame: inspector.Debugger.CallFrame): string {

diff --git a/src/agent/v8/inspector-debugapi.ts b/src/agent/v8/inspector-debugapi.ts
@@ -370,7 +370,7 @@ export class InspectorDebugApi implements debugapi.DebugApi {
 
       const res = this.v8Inspector.setBreakpointByUrl({
         lineNumber: line - 1,
-        url: matchingScript,
+        url: `file://${matchingScript}`,
         columnNumber: column - 1,
         condition: breakpoint.condition || undefined
       });