Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Commit

Permalink
Merge branch 'master' into id-todo
Browse files Browse the repository at this point in the history
  • Loading branch information
JustinBeckwith authored Feb 8, 2019
2 parents 9a4c0cc + 2b52a66 commit 3657b79
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 24 deletions.
27 changes: 13 additions & 14 deletions src/agent/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ export interface AliasContext {
}

export interface CloudRepoSourceContext {
repoId: RepoId;
revisionId: string;
aliasName?: string;
aliasContext: AliasContext;
cloudRepo: {
repoId: RepoId; revisionId: string;
aliasName?: string; aliasContext: AliasContext;
};
}

export interface CloudWorkspaceId {
Expand All @@ -58,22 +58,21 @@ export interface CloudWorkspaceId {
}

export interface CloudWorkspaceSourceContext {
workspaceId: CloudWorkspaceId;
snapshotId: string;
cloudWorkspace: {workspaceId: CloudWorkspaceId; snapshotId: string;};
}

export interface GerritSourceContext {
hostUri: string;
gerritProject: string;
// one of:
revisionId?: string;
aliasName?: string;
aliasContext?: AliasContext;
gerrit: {
hostUri: string; gerritProject: string;
// one of:
revisionId?: string;
aliasName?: string;
aliasContext?: AliasContext;
};
}

export interface GitSourceContext {
url: string;
revisionId: string;
git: {url: string; revisionId: string;};
}

export interface ResolvedDebugAgentConfig extends GoogleAuthOptions {
Expand Down
10 changes: 0 additions & 10 deletions src/agent/debuglet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -402,16 +402,6 @@ export class Debuglet extends EventEmitter {
// This is ignorable.
}

// TODO: This code can be removed now that we support only Node 6+.
if (utils.satisfies(process.version, '5.2 || <4')) {
// Using an unsupported version. We report an error
// message about the Node.js version, but we keep on
// running. The idea is that the user may miss the error
// message on the console. This way we can report the
// error when the user tries to set a breakpoint.
that.logger.error(NODE_VERSION_MESSAGE);
}

// We can register as a debuggee now.
that.logger.debug('Starting debuggee, project', project);
that.running = true;
Expand Down

0 comments on commit 3657b79

Please sign in to comment.