This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
feat!: Add ability to store breakpoint data in firebase realtime database #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase (#1067) * Checkpoint on Firebase controller. Error handling and tests still need work. * Move api key and db url to the client's control * Some changes to work with the cli implementation - We now use a top level 'cdbg' node - Add timestamp with breakpoint is finalized - When a snapshot triggers, a separate node is used for the complete snapshot data under final. * Fix tests that relied on debuglet.stop(). Also disable the tests that aren't working yet, and remove a bunch of console.log messages. * Use underscores in label keys. * Replace console.log with util.debuglog. Co-authored-by: Jason Borg <jcborg@google.com>
* Fix and re-enable previously broken tests
product-auto-label
bot
added
size: xl
This will provide a consistent log level throughout the codebase.
Codecov Report
@@ Coverage Diff @@
## main #1076 +/- ##
==========================================
- Coverage 66.86% 66.11% -0.76%
==========================================
Files 20 21 +1
Lines 1648 1750 +102
Branches 335 352 +17
==========================================
+ Hits 1102 1157 +55
- Misses 469 510 +41
- Partials 77 83 +6
Continue to review full report at Codecov.
|
jasonborg
approved these changes
May 11, 2022
bcoe
approved these changes
May 12, 2022
| import * as stackdriver from '../types/stackdriver'; | ||
|
|
||
| const BREAKPOINT_ACTION_MESSAGE = | ||
| 'The only currently supported breakpoint actions' + ' are CAPTURE and LOG.'; |
There was a problem hiding this comment.
nit: I don't think two strings need to be appended together here, confused me slightly.
There was a problem hiding this comment.
Cute. I'll fix that later; I assume that the linter moved the linebreak and it's solidly nonsense now.
|
Thanks for the reviews! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1071 🦕