Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

chore!: upgrade to node 14 #1160

Merged
merged 3 commits into from
Aug 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/sync-repo-settings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ branchProtectionRules:
- "ci/kokoro: System test"
- docs
- lint
- test (12)
- test (14)
- test (16)
- test (18)
- cla/google
- windows
- OwlBot Post Processor
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [12, 14, 16]
node: [14, 16, 18, 20]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand Down
24 changes: 0 additions & 24 deletions .kokoro/continuous/node12/common.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/continuous/node12/lint.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/continuous/node12/samples-test.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/continuous/node12/system-test.cfg

This file was deleted.

Empty file.
24 changes: 0 additions & 24 deletions .kokoro/presubmit/node12/common.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/presubmit/node12/samples-test.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/presubmit/node12/system-test.cfg

This file was deleted.

Empty file.
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
],
"license": "Apache-2.0",
"engines": {
"node": ">=12.0.0"
"node": ">=14.0.0"
},
"files": [
"build/src"
Expand All @@ -44,15 +44,15 @@
"precompile": "gts clean"
},
"dependencies": {
"@google-cloud/common": "^4.0.0",
"@google-cloud/common": "^5.0.0",
"@fastify/busboy": "1.1.0",
"acorn": "^8.0.0",
"coffeescript": "^2.0.0",
"console-log-level": "^1.4.0",
"extend": "^3.0.2",
"findit2": "^2.2.3",
"firebase-admin": "^10.0.0",
"gcp-metadata": "^5.0.0",
"gcp-metadata": "^6.0.0",
"p-limit": "^3.0.1",
"semver": "^7.0.0",
"source-map": "^0.8.0-beta.0",
Expand Down Expand Up @@ -81,7 +81,7 @@
"cpy-cli": "^4.0.0",
"cross-env": "^7.0.0",
"execa": "^5.0.0",
"gts": "^3.1.0",
"gts": "^5.0.0",
"linkinator": "^4.0.0",
"mocha": "^9.2.2",
"mv": "^2.1.1",
Expand All @@ -91,7 +91,7 @@
"proxyquire": "^2.0.0",
"teeny-request": "^8.0.0",
"tmp-promise": "^3.0.0",
"typescript": "^4.6.4",
"typescript": "5.1.6",
"uuid": "^9.0.0"
}
}
21 changes: 12 additions & 9 deletions src/agent/debuglet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1049,15 +1049,18 @@
: now;
const expiryTime = createdTime + this.config.breakpointExpirationSec;

setTimeout(() => {
this.logger.info('Expiring breakpoint ' + breakpoint.id);
breakpoint.status = {
description: {format: 'The snapshot has expired'},
isError: true,
refersTo: StatusMessage.BREAKPOINT_AGE,
};
this.completeBreakpoint_(breakpoint);
}, (expiryTime - now) * 1000).unref();
setTimeout(

Check warning on line 1052 in src/agent/debuglet.ts

View check run for this annotation

Codecov / codecov/patch

src/agent/debuglet.ts#L1052

Added line #L1052 was not covered by tests
() => {
this.logger.info('Expiring breakpoint ' + breakpoint.id);
breakpoint.status = {

Check warning on line 1055 in src/agent/debuglet.ts

View check run for this annotation

Codecov / codecov/patch

src/agent/debuglet.ts#L1054-L1055

Added lines #L1054 - L1055 were not covered by tests
description: {format: 'The snapshot has expired'},
isError: true,
refersTo: StatusMessage.BREAKPOINT_AGE,
};
this.completeBreakpoint_(breakpoint);

Check warning on line 1060 in src/agent/debuglet.ts

View check run for this annotation

Codecov / codecov/patch

src/agent/debuglet.ts#L1060

Added line #L1060 was not covered by tests
},
(expiryTime - now) * 1000
).unref();
}

/**
Expand Down
Loading