Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

fix: increase capture limit to allow Windows tests to pass #1188

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

mctavish
Copy link
Contributor

@mctavish mctavish commented Dec 20, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1187 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. labels Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd4dee0) 61.72% compared to head (7992249) 61.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1188   +/-   ##
=======================================
  Coverage   61.72%   61.72%           
=======================================
  Files          17       17           
  Lines        1309     1309           
  Branches      257      257           
=======================================
  Hits          808      808           
  Misses        447      447           
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mctavish mctavish marked this pull request as ready for review December 20, 2023 16:41
@mctavish mctavish requested review from a team as code owners December 20, 2023 16:41
@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2023
@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2023
@mctavish mctavish merged commit 728b90e into googleapis:main Dec 20, 2023
17 checks passed
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows unit tests are broken
2 participants