Add ScopeMirror traversal to state.js #142

cristiancavalli · 2016-07-25T18:07:13Z

Replace the FrameMirror.localValue code path with ScopeMirror
traversal and rewrite the arguments collector to only serialize
arguments which are not matched by name with a more deeply-scoped
value.

cristiancavalli · 2016-07-25T18:07:29Z

@matthewloring @ofrobots PTAL

cristiancavalli · 2016-08-01T02:07:38Z

@ofrobots @matthewloring CI is now green and ready for another look

matthewloring · 2016-08-01T04:29:09Z

Could this PR include tests for the case where nested variables have the same name? Also, is this the change that resolves error objects defined in catch blocks?

cristiancavalli · 2016-08-01T21:44:02Z

@matthewloring updated

matthewloring · 2016-08-01T23:46:27Z

Let's look into the 0.12/4.0 behavioral difference from the failing test.

test/test-v8debugapi.js

@@ -587,8 +601,13 @@ describe('v8debugapi', function() {

          var topFrame = bp.stackFrames[0];
          assert.equal(topFrame['function'], 'foo');
-          assert.equal(topFrame.arguments[0].name, 'n');
-          assert.equal(topFrame.arguments[0].value, '3');
+          if (semver.satisfies(process.version, '<1.6')) {


cristiancavalli · 2016-08-09T18:44:44Z

@ofrobots @matthewloring any traction on this?

test/standalone/test-duplicate-nested-expressions.js

+/*4*/ var a = 10;
+/*5*/ a += 1;
+/*6*/ return (function (b) {
+/*7*/   var a = 10;


matthewloring · 2016-08-09T20:04:42Z

LGTM w/ nit on my end. We should have ofrobots@ take a look at the version dependencies introduced in the tests.

lib/state.js

+      varTableIndex: ARG_LOCAL_LIMIT_MESSAGE_INDEX
+    }];
+  } else {
+    args = [{


matthewloring · 2016-08-11T22:13:59Z

Could we add additional tests for each of the internal bugs addressed in this issue.

cristiancavalli · 2016-08-12T20:08:01Z

@matthewloring @ofrobots Feedback integrated; looks like Travis is having troubles right now and the builds are just sitting there. Tested locally with Node.JS 0.12 and 6.3.1

cristiancavalli · 2016-08-12T21:31:18Z

Not sure why v5 failed, passes locally on my machine and that test was not touched. Travis won't let me restart the build though.

lib/state.js

+          if (argMatch && (semver.satisfies(process.version, '<1.6'))) {
+            // If the version is lower than 1.6 we will use the frame's argument
+            // list to source argument values, yet the ScopeMirror traversal for
+            // node these Node versions will also return the arguments.


test/standalone/fat-arrow.js

+/*7*/ };
+/*8*/ return a(1);
+/*9*/}
+/*10*/module.exports = foo;


matthewloring · 2016-08-13T04:04:18Z

LGTM with a few nits. Let's get a final sign off from @ofrobots.

cristiancavalli · 2016-08-13T05:30:27Z

@matthewloring @ofrobots Updated

test/standalone/fat-arrow.js

@@ -0,0 +1,11 @@
+/*1* KEEP THIS CODE AT THE TOP TO AVOID LINE NUMBER CHANGES */ /* jshint shadow:true */


ofrobots · 2016-08-15T17:28:58Z

lgtm once comments are addressed

Replace the `FrameMirror.localValue` code path with `ScopeMirror` traversal and rewrite the arguments collector to only serialize arguments which are not matched by name with a more deeply-scoped value. Add closure scope type to filter list because of confusion with node.JS requires. Add tests for nested, confounding variable names and try/catch. 03/08/2016-10:07 PST Update to use locals only becuase of 0.12 behaviour. 12/08/2016-12:40 PST Update with full-range of test-cases gathered from bug-bash. Add more testing around locals for node versions less than 1.6. Add more documentation around new ScopeMirror traversal. Add 'this' context extraction and tests. 15/08/2016-10:54 PST Respond to PR feedback

cristiancavalli · 2016-08-15T18:27:14Z

@ofrobots @matthewloring Updated. I don't have the power to merge in though

ofrobots · 2016-08-15T18:35:55Z

You have the power now.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2016

cristiancavalli force-pushed the use_scope_mirrors branch from d776780 to 48781ed Compare August 1, 2016 01:59

cristiancavalli force-pushed the use_scope_mirrors branch from 48781ed to ce97861 Compare August 1, 2016 21:43

cristiancavalli force-pushed the use_scope_mirrors branch 4 times, most recently from b8dad03 to 065a8f8 Compare August 3, 2016 21:28

matthewloring reviewed Aug 3, 2016
View reviewed changes

matthewloring reviewed Aug 9, 2016
View reviewed changes

test/standalone/test-duplicate-nested-expressions.js

/*4*/ var a = 10;

/*5*/ a += 1;

/*6*/ return (function (b) {

/*7*/ var a = 10;

This comment was marked as spam.

Sign in to view

ofrobots reviewed Aug 9, 2016
View reviewed changes

lib/state.js

varTableIndex: ARG_LOCAL_LIMIT_MESSAGE_INDEX

}];

} else {

args = [{

This comment was marked as spam.

Sign in to view

cristiancavalli force-pushed the use_scope_mirrors branch 2 times, most recently from c90c24f to 72e780d Compare August 12, 2016 20:02

matthewloring reviewed Aug 13, 2016
View reviewed changes

test/standalone/fat-arrow.js

/*7*/ };

/*8*/ return a(1);

/*9*/}

/*10*/module.exports = foo;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

cristiancavalli force-pushed the use_scope_mirrors branch 2 times, most recently from 8c72049 to ea5fc89 Compare August 13, 2016 05:29

cristiancavalli force-pushed the use_scope_mirrors branch from ea5fc89 to 59d060d Compare August 13, 2016 05:37

ofrobots reviewed Aug 15, 2016
View reviewed changes

test/standalone/fat-arrow.js

@@ -0,0 +1,11 @@

/*1* KEEP THIS CODE AT THE TOP TO AVOID LINE NUMBER CHANGES */ /* jshint shadow:true */

This comment was marked as spam.

Sign in to view

cristiancavalli force-pushed the use_scope_mirrors branch 2 times, most recently from ea8d60d to 3fa14c6 Compare August 15, 2016 18:00

cristiancavalli merged commit edcfb04 into googleapis:master Aug 15, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ScopeMirror traversal to state.js #142

Add ScopeMirror traversal to state.js #142

cristiancavalli commented Jul 25, 2016

cristiancavalli commented Jul 25, 2016

cristiancavalli commented Aug 1, 2016

matthewloring commented Aug 1, 2016

cristiancavalli commented Aug 1, 2016

matthewloring commented Aug 1, 2016

This comment was marked as spam.

cristiancavalli commented Aug 9, 2016

This comment was marked as spam.

matthewloring commented Aug 9, 2016

This comment was marked as spam.

matthewloring commented Aug 11, 2016

cristiancavalli commented Aug 12, 2016 •

edited

Loading

cristiancavalli commented Aug 12, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

matthewloring commented Aug 13, 2016

cristiancavalli commented Aug 13, 2016

This comment was marked as spam.

ofrobots commented Aug 15, 2016

cristiancavalli commented Aug 15, 2016

ofrobots commented Aug 15, 2016

		@@ -0,0 +1,11 @@
		/1 KEEP THIS CODE AT THE TOP TO AVOID LINE NUMBER CHANGES / / jshint shadow:true */

Add ScopeMirror traversal to state.js #142

Add ScopeMirror traversal to state.js #142

Conversation

cristiancavalli commented Jul 25, 2016

cristiancavalli commented Jul 25, 2016

cristiancavalli commented Aug 1, 2016

matthewloring commented Aug 1, 2016

cristiancavalli commented Aug 1, 2016

matthewloring commented Aug 1, 2016

This comment was marked as spam.

cristiancavalli commented Aug 9, 2016

This comment was marked as spam.

matthewloring commented Aug 9, 2016

This comment was marked as spam.

matthewloring commented Aug 11, 2016

cristiancavalli commented Aug 12, 2016 • edited Loading

cristiancavalli commented Aug 12, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

matthewloring commented Aug 13, 2016

cristiancavalli commented Aug 13, 2016

This comment was marked as spam.

ofrobots commented Aug 15, 2016

cristiancavalli commented Aug 15, 2016

ofrobots commented Aug 15, 2016

cristiancavalli commented Aug 12, 2016 •

edited

Loading