This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Add support for source-context #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #3 gcloud cli generates a source-context.json file on deployment. This works for Java already, but is expected to start working for Node.js as well as per some work being done by the Cloud Debug team.
| @@ -102,21 +115,31 @@ DebugletApi.prototype.registerError = function(message) { | |||
| DebugletApi.prototype.register_ = function(errorMessage, callback) { | |||
| var that = this; | |||
|
|
|||
| var pjson = require('../package.json'); | |||
| var cwd = process.cwd(); | |||
| var mainScript = path.relative(cwd, process.argv[1]); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3
gcloud cli generates a source-context.json file on deployment. This works for
Java already, but is expected to start working for Node.js as well as per some
work being done by the Cloud Debug team.
There are no tests available at the moment, but I will add them as a follow-on. This is tracked by: #15