-
Notifications
You must be signed in to change notification settings - Fork 51
fix precedence for where the projectId is acquired from #193
Conversation
apologies for some of the formatting/indentation changes. |
@@ -132,13 +135,14 @@ Controller.prototype.register_ = function(errorMessage, callback) { | |||
uri: API + '/debuggees/register', | |||
method: 'POST', | |||
json: true, | |||
body: { debuggee: debuggee } | |||
body: {debuggee: debuggee} |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
// We should get an error if we are not on GCP. | ||
that.onGCP = !err; | ||
|
||
// We perfer to use the locally available projectId as that is least |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial scan looks good with a couple questions
var Debuglet = require('../../src/agent/debuglet.js'); | ||
var extend = require('extend'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -44,25 +43,26 @@ var errorBp = { | |||
location: { path: 'fixtures/foo.js', line: 2 } | |||
}; | |||
var fakeDebug = { | |||
request: request | |||
request: request // avoid authing. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
projectId: 'project-via-config', | ||
credentials: require('../fixtures/gcloud-credentials.json') | ||
}); | ||
var debug = require('../../')(config); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
||
describe('test-config-credentials', function() { | ||
var debuglet = null; | ||
var envProject = process.env.GCLOUD_PROJECT; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
No description provided.