Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

fix stale code/test from test-controller #213

Merged
merged 1 commit into from
Dec 27, 2016
Merged

fix stale code/test from test-controller #213

merged 1 commit into from
Dec 27, 2016

Conversation

ofrobots
Copy link
Contributor

The controller no longer automatically fetches the projectId from metadata service. The mock and corresponding tests were no longer necessary.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 27, 2016
matthewloring
matthewloring approved these changes Dec 27, 2016
View reviewed changes
Copy link
Contributor

@matthewloring matthewloring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there tests elsewhere checking we retrieve the project number correctly using the new mechanism?

@ofrobots
Copy link
Contributor Author

Yep. test-debuglet.js exercises this path adequately.

@ofrobots ofrobots merged commit c48c7db into googleapis:master Dec 27, 2016
@ofrobots ofrobots deleted the unnecessary-mock branch December 27, 2016 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matthewloring matthewloring matthewloring approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofrobots @matthewloring @googlebot