This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Fix bugs in findScripts #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
PTAL. |
ofrobots
force-pushed
the
findScripts
branch
2 times, most recently
from
90b2ecd
to
e27eb52
Compare
matthewloring
approved these changes
Jan 20, 2017
|
|
||
| /** | ||
| * Given an list available files and a script path to match, this function tries | ||
| * to resolve the script patch a (hopefully unique) match in the file list |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| /** | ||
| * Given an list available files and a script path to match, this function tries | ||
| * to resolve the script patch a (hopefully unique) match in the file list | ||
| * irrespective of the script path. This can be useful because repo file paths |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
* Code was buggy when fileList had only one entry. * Fix bug in pathToRegExp that was not considering '.' as literal. * Make the code easier to unit test. * More unit tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fileStatshad only one entry.pathToRegExpthat was not considering '.' as literal.