Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

lint, tooling, and other misc. changes #304

Merged
merged 2 commits into from
Jul 7, 2017
Merged

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Jul 7, 2017

  • Remove jshint files and devDependency
  • Update tslint config. Use typechecked lint. Remove options that are subsumed
    by the compiler now.
  • Start shipping type definitions.
  • Address newly found lint errors.
  • Formatting.

* Remove jshint files and devDependency
* Update tslint config. Use typechecked lint. Remove options that are subsumed
  by the compiler now.
* Start shipping type definitions.
* Address newly found lint errors.
* Formatting.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 7, 2017
Copy link
Contributor

@DominicKramer DominicKramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also, jshint was also used in ./bin/run-test.sh, but is now commented out. I think that line can now be removed entirely.

@ofrobots ofrobots merged commit f13d122 into googleapis:master Jul 7, 2017
@ofrobots ofrobots deleted the tooling branch July 7, 2017 22:29
@ofrobots
Copy link
Contributor Author

ofrobots commented Jul 7, 2017

Thanks, removed the commented out jshint invocation from run-test.sh

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants