-
Notifications
You must be signed in to change notification settings - Fork 51
Elaborate on async stack trace warning #340
Conversation
eb55ee2
to
b89a553
Compare
0508566
to
f30a52e
Compare
f30a52e
to
e3ce1fb
Compare
src/agent/debuglet.ts
Outdated
'INSPECTOR_ASYNC_STACK_TRACES_NOT_AVAILABLE') { | ||
console.log( | ||
'The current debug agent does not use Inspector async stack ' + | ||
'traces. The above warning will not affect the debug agent.'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/test-debuglet.ts
Outdated
it('should elaborate on inspector warning on 32 bit', function(done) { | ||
let logText = ''; | ||
const oldLog = console.log; | ||
console.log = function(s: string) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/test-debuglet.ts
Outdated
@@ -315,6 +316,49 @@ describe('Debuglet', function() { | |||
assert.deepEqual(mergedConfig, compareConfig); | |||
}); | |||
|
|||
it('should elaborate on inspector warning on 32 bit', function(done) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/test-debuglet.ts
Outdated
const arch = process.arch; | ||
const nodeVersion = /v(\d+\.\d+\.\d+)/.exec(process.version); | ||
if (!nodeVersion || nodeVersion.length < 2) { | ||
(assert as any).fail(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/test-debuglet.ts
Outdated
} else if (semver.satisfies(nodeVersion[1], '>=8') && | ||
(arch === 'ia32' || arch === 'x86')) { | ||
assert(logText.includes( | ||
'The current debug agent does not use ' + |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/agent/debuglet.ts
Outdated
'INSPECTOR_ASYNC_STACK_TRACES_NOT_AVAILABLE') { | ||
console.log( | ||
'The current debug agent does not use Inspector async stack ' + | ||
'traces. The above warning will not affect the debug agent.'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/test-debuglet.ts
Outdated
delete process.env.GCLOUD_PROJECT; | ||
oldLog = console.log; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits.
test/test-debuglet.ts
Outdated
// TODO: Handle the case where debuglet.debuggee is undefined | ||
assert.equal((debuglet.debuggee_ as Debuggee).project, projectId); | ||
const arch = process.arch; | ||
if (semver.satisfies(process.version, '>=8') && |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/agent/util/utils.ts
Outdated
@@ -24,7 +24,10 @@ export const messages = { | |||
CAPTURE_BREAKPOINT_DATA: 'Error trying to capture snapshot data: ', | |||
INVALID_LINE_NUMBER: 'Invalid snapshot position: ', | |||
COULD_NOT_FIND_OUTPUT_FILE: | |||
'Could not determine the output file associated with the transpiled input file' | |||
'Could not determine the output file associated with the transpiled input file', | |||
ASYNC_TRACES_WARNING: 'The Stackdriver debug agent does not use Inspector ' + |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/test-debuglet.ts
Outdated
|
||
after(function() { process.env.GCLOUD_PROJECT = oldGP; }); | ||
|
||
beforeEach(function() { | ||
beforeEach(() => { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
test/test-debuglet.ts
Outdated
delete process.env.GCLOUD_PROJECT; | ||
nocks.oauth2(); | ||
}); | ||
|
||
afterEach(function() { nock.cleanAll(); }); | ||
afterEach(() => { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Add a log message address the 'INSPECTOR_ASYNC_STACK_TRACES_NOT_AVAILABLE' warning.