fix: Address startup failure from file access errors #379

DominicKramer · 2017-12-14T21:41:04Z

fixes: #377

src/agent/debuglet.ts

@@ -294,6 +294,9 @@ export class Debuglet extends EventEmitter {
    try {
      fileStats = await scanner.scan(
          !id, that.config.workingDirectory, /.js$|.map$/);
+      fileStats.errors().forEach(err => {


src/agent/io/scanner.ts

+          reject(error);
+        }
+        else {
+          let d: string|undefined;


test/fixtures/project-cannot-read-files/cannot-read-1.js

@@ -0,0 +1 @@
+This file cannot be read.


ofrobots

LGTM w/ nit.

test/test-debuglet.ts

@@ -444,6 +447,73 @@ describe('Debuglet', () => {
      debuglet.start();
    });

+    it('should not fail if files cannot be read', (done) => {
+      const MOCKED_DIRECTORY = process.cwd();
+      const errors: Array < {


Also tests were added to verify that if a file cannot be read during a filesystem scan, a warning is issued instead of an error.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 14, 2017

DominicKramer requested a review from a team December 18, 2017 18:28

ofrobots reviewed Dec 18, 2017

View reviewed changes

DominicKramer mentioned this pull request Dec 18, 2017

GKE: Error scanning the filesystem #377

Closed

DominicKramer force-pushed the fix/startup-error-on-bad-files branch from 55275db to 3eba764 Compare December 19, 2017 23:26

ofrobots approved these changes Dec 20, 2017

View reviewed changes

test/test-debuglet.ts

@@ -444,6 +447,73 @@ describe('Debuglet', () => {

debuglet.start();

});

it('should not fail if files cannot be read', (done) => {

const MOCKED_DIRECTORY = process.cwd();

const errors: Array < {

This comment was marked as spam.

Sign in to view

DominicKramer added 16 commits December 20, 2017 10:17

Convert spanner.ts to async/await

fe0f13e

Update findFiles to only resolve/reject on 'end'

601e9ab

Only warn on files that cannot be read

88e22ec

Also tests were added to verify that if a file cannot be read during a filesystem scan, a warning is issued instead of an error.

Remove repeated code

71eafd9

Run gts fix

9fbf0ac

Add additional tests for fileStats.errors().size

75e552f

Stop the debuglet after the test is done

26e8822

Add broken-link.js

2893dce

Add tests to verify broken links are ignored

fddd732

Add scanner tests

d8c23d1

Add log tests to test-debuglet for invalid files

80117b4

Run gts fix

c520e69

Create a broken-links dir for tests

3b38d35

Address GitHub comments

cfcff86

Fix compiler errors associated with the rebase

b1ef474

Regenerate package-lock.json

0250fe7

DominicKramer force-pushed the fix/startup-error-on-bad-files branch from 3eba764 to 0250fe7 Compare December 20, 2017 18:35

DominicKramer merged commit 5c93c44 into googleapis:master Dec 20, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Address startup failure from file access errors #379

fix: Address startup failure from file access errors #379

DominicKramer commented Dec 14, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

ofrobots left a comment

This comment was marked as spam.

fix: Address startup failure from file access errors #379

fix: Address startup failure from file access errors #379

Conversation

DominicKramer commented Dec 14, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

ofrobots left a comment

Choose a reason for hiding this comment

This comment was marked as spam.