Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

test: use unique service context for e2e tests #638

Merged
merged 5 commits into from
Feb 15, 2019

Conversation

ofrobots
Copy link
Contributor

Concurrent execution of the e2e tests is causing flakiness.

Concurrent execution of the e2e tests is causing flakiness.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 14, 2019
DominicKramer
DominicKramer previously approved these changes Feb 14, 2019
Copy link
Contributor

@DominicKramer DominicKramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the tests pass.

@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #638 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #638      +/-   ##
==========================================
- Coverage   92.91%   92.89%   -0.03%     
==========================================
  Files          38       38              
  Lines        3544     3546       +2     
  Branches      105      105              
==========================================
+ Hits         3293     3294       +1     
- Misses        228      229       +1     
  Partials       23       23
Impacted Files Coverage Δ
src/debuggee.ts 78.57% <ø> (ø) ⬆️
test/nocks.ts 83.33% <50%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a9ea83...884a8a3. Read the comment docs.

@DominicKramer DominicKramer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2019
@ofrobots
Copy link
Contributor Author

Okay, I finally understand the flakiness. Should be fixed now.

TBR= @DominicKramer

@ofrobots ofrobots merged commit 671317e into googleapis:master Feb 15, 2019
@ofrobots ofrobots deleted the unique-e2e branch February 15, 2019 02:51
@DominicKramer
Copy link
Contributor

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants