This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
chore: cleanup unused files & npm audit fix
#716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
JustinBeckwith
changed the title
npm audit fix
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
=======================================
Coverage 85.65% 85.65%
=======================================
Files 13 13
Lines 941 941
Branches 191 191
=======================================
Hits 806 806
Misses 74 74
Partials 61 61Continue to review full report at Codecov.
|
DominicKramer
approved these changes
May 31, 2019
There was a problem hiding this comment.
LGTM once the tests pass. It looks like their failure could be a Kokoro issue:
[11:03:15][ERROR] Failed to get build config
com.google.devtools.kokoro.config.ConfigException: Couldn't find build configuration under /tmp/workspace/workspace/cloud-devrel/client-libraries/nodejs/presubmit/googleapis/cloud-debug-nodejs/node8/system-test/src/github/cloud-debug-nodejs/.kokoro/presubmit/node8
@JustinBeckwith have you seen this type of error before?
|
Now the tests are all green, and so I'm going to land this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to package.json are re-arranging the sections to be consistent with all of our other README's, and an
npm audit fix.