Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove old kokoro configs and unused portions of tests #458

Merged
merged 2 commits into from
Apr 6, 2019

Conversation

nolanmar511
Copy link
Contributor

@nolanmar511 nolanmar511 commented Apr 5, 2019

This change deletes Kokoro configs no longer used after #452 and #441. Also remove configs and poritions of testing for testing with v8-canary, since that testing is now part of pprof-nodejs.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 5, 2019
@nolanmar511 nolanmar511 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 5, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 5, 2019
@nolanmar511 nolanmar511 closed this Apr 5, 2019
@nolanmar511 nolanmar511 reopened this Apr 5, 2019
@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #458 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   75.94%   75.94%           
=======================================
  Files           4        4           
  Lines         212      212           
  Branches       24       24           
=======================================
  Hits          161      161           
  Misses         48       48           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c1255...573e274. Read the comment docs.

@nolanmar511 nolanmar511 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 5, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 5, 2019
@nolanmar511 nolanmar511 changed the title chore: remove old kokoro configs chore: remove old kokoro configs and unused portions of tests Apr 5, 2019
@nolanmar511 nolanmar511 requested review from jqll and kalyanac and removed request for jqll April 5, 2019 22:02
@aalexand aalexand merged commit 71a1bee into googleapis:master Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants