Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update dependencies and tsconfig to support Node 6 #466

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

nolanmar511
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2019
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we just rely on the version in the tsconfig, which as of today in gts@0.9.0 is es2015. When you upgrade to gts@1.0.0, it's gonna bump to es2016 by design. Why hard code it?

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #466 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #466   +/-   ##
=======================================
  Coverage   75.94%   75.94%           
=======================================
  Files           4        4           
  Lines         212      212           
  Branches       24       24           
=======================================
  Hits          161      161           
  Misses         48       48           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 081c153...f29da31. Read the comment docs.

@nolanmar511 nolanmar511 changed the title fix: add es2015 as target for tsconfig.json fix: update dependencies and tsconfig to support Node 6 Apr 26, 2019
@nolanmar511
Copy link
Contributor Author

Clarified the title.
We have continuous integration tests which use Node 6, and those are failing.
I want to get those tests passing, the go through a more conscious effort to drop support for Node 6.

@nolanmar511
Copy link
Contributor Author

Closing this.

It's probably just too hard to support Node 6, and Node 6 is basically end of life anyways.

@nolanmar511
Copy link
Contributor Author

Actually, want to get this change in.
It will give time for a more graceful wrap-up of Node 6 support.

@kalyanac kalyanac merged commit b7b0714 into googleapis:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants