Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to .nycrc with --all enabled #473

Merged
merged 1 commit into from
Apr 29, 2019
Merged

update to .nycrc with --all enabled #473

merged 1 commit into from
Apr 29, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Apr 29, 2019

to work properly, nyc should also be updated to 14

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2019
@nolanmar511 nolanmar511 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 29, 2019
Copy link
Contributor

@nolanmar511 nolanmar511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM pending Kokoro tests passing.

@nolanmar511 nolanmar511 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 29, 2019
@bcoe
Copy link
Contributor Author

bcoe commented Apr 29, 2019

@nolanmar511 👍 I'm about to send an automated PR for all repos, which might recreate this PR.

@nolanmar511 nolanmar511 merged commit 5b67176 into master Apr 29, 2019
@nolanmar511 nolanmar511 deleted the nycrc-update branch April 29, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement. kokoro:run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants