build!: upgrade engines field to >=8.10.0 #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
nolanmar511
reviewed
May 2, 2019
| @@ -96,6 +96,6 @@ | |||
| ] | |||
| }, | |||
| "engines": { | |||
| "node": ">=6.12.3 <8.0.0 || >=8.9.4 <10.0.0 || >=10.4.1" | |||
| "node": ">=8.10.0" | |||
There was a problem hiding this comment.
For context, why is support for 8.9.X dropped?
Also, for this module, the engine would need to be ">=8.10.0 <10.0.0 || >=10.4.1". Some versions of Node 10 are not compatible with the profile.
JustinBeckwith
approved these changes
May 2, 2019
nolanmar511
added a commit
that referenced
this pull request
May 2, 2019
This reverts commit 2f30df4.
kalyanac
pushed a commit
that referenced
this pull request
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops support for all Node.js versions < 8.10.0, please upgrade
BREAKING CHANGE: library now requires Node >= 8.10.0