Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @google-cloud/common to v1 #482

Merged
merged 2 commits into from
May 13, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 9, 2019

This PR contains the following updates:

Package Type Update Change References
@​google-cloud/common dependencies major ^0.31.0 -> ^1.0.0 source

Release Notes

googleapis/nodejs-common

v1.0.0

Compare Source

Bug Fixes
Build System
Miscellaneous Chores
BREAKING CHANGES
  • deps: this will ship async/await in the generated code
  • upgrade engines field to >=8.10.0 (#​412)

v0.32.1

Compare Source

Bug Fixes
Build System
Miscellaneous Chores
BREAKING CHANGES
  • deps: this will ship async/await in the generated code
  • upgrade engines field to >=8.10.0 (#​412)

v0.32.0

Compare Source

04-02-2019 15:11 PDT

BREAKING CHANGE: This PR removes the ability to configure a custom implementation of the Request module. This was necessary when we were migrating from request to teeny-request, but that migration is now complete. All interfaces at accepted a custom implementation of request will no longer accept one. teeny-request is now just included in the box.


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 9, 2019
@nolanmar511
Copy link
Contributor

Tests failing with:

ts/src/profiler.ts:299:7 - error TS2322: Type '{ baseUrl: string; scopes: string[]; packageJson: any; requestModule: any; }' is not assignable to type 'ServiceConfig'.
  Object literal may only specify known properties, and 'requestModule' does not exist in type 'ServiceConfig'.

299       requestModule: request as any,
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Will need to update code.

@nolanmar511 nolanmar511 self-assigned this May 9, 2019
@callmehiphop
Copy link

@nolanmar511 pretty sure the common module dropped support for supplying a custom request module, so I think just deleting those lines will make CI happy? No idea if this module depended on that functionality or not.

@renovate renovate bot force-pushed the renovate/google-cloud-common-1.x branch from 43a848a to 33fca0a Compare May 10, 2019 20:48
@nolanmar511 nolanmar511 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2019
@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #482 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #482     +/-   ##
=========================================
- Coverage   73.33%   73.23%   -0.1%     
=========================================
  Files           6        6             
  Lines         270      269      -1     
  Branches       56       56             
=========================================
- Hits          198      197      -1     
  Misses         57       57             
  Partials       15       15
Impacted Files Coverage Δ
ts/src/profiler.ts 84.9% <ø> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcf179...62936dd. Read the comment docs.

@nolanmar511
Copy link
Contributor

Merging in.

Code coverage dropped by 0.1% because a line that was removed has coverage. I'm ignoring that failure.

@nolanmar511 nolanmar511 merged commit 10ba3fb into master May 13, 2019
@renovate renovate bot deleted the renovate/google-cloud-common-1.x branch May 13, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants