Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: retry npm install in system test when the command hangs #491

Merged
merged 2 commits into from
May 21, 2019

Conversation

nolanmar511
Copy link
Contributor

@nolanmar511 nolanmar511 commented May 21, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 21, 2019
@nolanmar511 nolanmar511 changed the title DO NOT REVIEW: chore: use npm install retry script in system test chore: use npm install retry script in system test May 21, 2019
@nolanmar511 nolanmar511 requested a review from kalyanac May 21, 2019 18:29
@nolanmar511 nolanmar511 changed the title chore: use npm install retry script in system test DO NOT REVIEW: chore: use npm install retry script in system test May 21, 2019
@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #491 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #491   +/-   ##
=======================================
  Coverage   73.13%   73.13%           
=======================================
  Files           6        6           
  Lines         268      268           
  Branches       56       56           
=======================================
  Hits          196      196           
  Misses         57       57           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c7cc14...7b99372. Read the comment docs.

@aalexand
Copy link
Contributor

@nolanmar511 The PR title needs some polish. Code lgtm.

@nolanmar511 nolanmar511 changed the title DO NOT REVIEW: chore: use npm install retry script in system test chore: retry npm install in system test when the command hangs May 21, 2019
@kalyanac kalyanac merged commit 5af2c80 into googleapis:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants