-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(breaking!): support API endpoint override #509
Conversation
There are two things I'll need to be careful about with respect to this change:
|
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
=========================================
- Coverage 76.57% 76.38% -0.2%
=========================================
Files 7 7
Lines 269 271 +2
Branches 56 56
=========================================
+ Hits 206 207 +1
- Misses 48 49 +1
Partials 15 15
Continue to review full report at Codecov.
|
Added a "do not merge" label because I'd like to get a release of @google-cloud/profiler out before merging this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks reasonable to me. @nolanmar511, let's try to figure out why release-please is not working on this repo, and release the next version of this library using automation.
No description provided.