Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dep): update to be compatible with @google-cloud/common 2.1.X #529

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

nolanmar511
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 14, 2019
@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #529 into master will decrease coverage by 0.47%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #529      +/-   ##
==========================================
- Coverage   76.38%   75.91%   -0.48%     
==========================================
  Files           7        7              
  Lines         271      274       +3     
  Branches       56       56              
==========================================
+ Hits          207      208       +1     
- Misses         49       50       +1     
- Partials       15       16       +1
Impacted Files Coverage Δ
ts/src/profiler.ts 88.41% <100%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b24522...6a1330f. Read the comment docs.

@nolanmar511
Copy link
Contributor Author

@JustinBeckwith -- Any guidance on making our headers compliant with header-check?

@JustinBeckwith
Copy link
Contributor

@nolanmar511 right now it's safe to ignore that - it shouldn't be required. Working with @bcoe to figure out how to roll this bot out :)

@nolanmar511 nolanmar511 merged commit 3fd0035 into googleapis:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants