Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): pin pprof #539

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Conversation

nolanmar511
Copy link
Contributor

@nolanmar511 nolanmar511 commented Sep 10, 2019

@google-cloud/profiler depends heavily on the pprof module.

We want to be sure that changes to pprof that introduce bugs or problems in @google-cloud/profiler can be caught by @google-cloud/profiler's presubmit tests, rather than immediately impacting @google-cloud/profiler as its running in prod.

This will allow us to concentrate testing in this repository, rather than duplicate all testing here and in https://github.com/google/pprof-nodejs.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 10, 2019
@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

Merging #539 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #539   +/-   ##
=======================================
  Coverage   75.73%   75.73%           
=======================================
  Files           7        7           
  Lines         272      272           
  Branches       56       56           
=======================================
  Hits          206      206           
  Misses         50       50           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfce0ee...1325a20. Read the comment docs.

@kalyanac kalyanac merged commit 470bf3c into googleapis:master Sep 11, 2019
package.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants