Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Node 12 #580

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Conversation

nolanmar511
Copy link
Contributor

This library did work with Node 12 prior to this change.

This change documents Node 12 support, and starts running integration tests with node 12.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 17, 2020
@nolanmar511 nolanmar511 requested a review from kalyanac January 17, 2020 23:00
@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #580 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   15.78%   15.78%           
=======================================
  Files           7        7           
  Lines       14406    14406           
  Branches       67       67           
=======================================
  Hits         2274     2274           
  Misses      12128    12128           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03cc4e7...3a360a7. Read the comment docs.

Copy link
Contributor

@kalyanac kalyanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending successful CI test

@nolanmar511 nolanmar511 merged commit e7cb85e into googleapis:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants