Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Node 14 #709

Merged
merged 1 commit into from
Nov 2, 2020
Merged

feat: add support for Node 14 #709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [10, 12, 13]
node: [10, 12, 13, 14]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of this, maybe we could remove 13, and add 15? Or separate PRs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll probably do this in separate PR.

I'm mainly adding this PR to reflect that the pprof dependency now has node 14 pre-built binaries (and so, I want our next release to be a minor version bump and the Node 14 binaries to be noted in its release notes); but our transition in updating tests for pprof-nodejs with the Node 14 release was interrupted by work to fix the memory leak, so pprof-nodejs's testing is quite to the point where we should add node 14 support here.

steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
Expand Down
13 changes: 13 additions & 0 deletions system-test/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,19 @@ func TestAgentIntegration(t *testing.T) {
timeout: gceTestTimeout,
benchDuration: gceBenchDuration,
},
{
InstanceConfig: proftest.InstanceConfig{
ProjectID: projectID,
Zone: zone,
Name: fmt.Sprintf("profiler-test-node14-%s", runID),
MachineType: "n1-standard-1",
},
name: fmt.Sprintf("profiler-test-node14-%s-gce", runID),
wantProfiles: wantProfiles,
nodeVersion: "14",
timeout: gceTestTimeout,
benchDuration: gceBenchDuration,
},
}

if *runBackoffTest {
Expand Down