build: use standard CI config #710
Conversation
google-cla
bot
added
the
cla: yes
| - cron: '0 2 * * *' # Run everyday, at 2AM UTC. | ||
| name: ci-profiler | ||
| jobs: | ||
| system-test: |
There was a problem hiding this comment.
@nolanmar511 curious - why do we run system tests as a GitHub action, and not rely on the default kokoro config we have set up elsewhere?
There was a problem hiding this comment.
Looking at my PR history, I think this was done to start running all tests with Node 13 a bit earlier (#585).
It may have also improve cove coverage results.
There was a problem hiding this comment.
Got it - so these are kinda 2 different things:
- We wanted node 13 testing faster here than we rolled it out elsewhere. Moving forward, we just need to be far more bullish about getting these in the matrix as soon as they're released. Good news is that 15 rolled out super fast.
- For system tests - I just don't want the duplicate config here to run it as an action unless we have a goodish reason :)
Codecov Report
@@ Coverage Diff @@
## master #710 +/- ##
=======================================
Coverage 86.00% 86.00%
=======================================
Files 7 7
Lines 1208 1208
Branches 97 97
=======================================
Hits 1039 1039
Misses 169 169 Continue to review full report at Codecov.
|
product-auto-label
bot
added
the
api: cloudprofiler
Was looking at #709, and wondering why this didn't come in the last sweep of global changes. I think we can let profiler have it's special sauce, while still staying on the centralized managed config.