Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: there's no reason to run the go linter #811

Closed
wants to merge 3 commits into from
Closed

Conversation

SurferJeffAtGoogle
Copy link
Contributor

No description provided.

@SurferJeffAtGoogle SurferJeffAtGoogle requested review from a team as code owners April 5, 2022 22:48
@product-auto-label product-auto-label bot added the api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. label Apr 5, 2022
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #811 (80836e3) into main (1772d79) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #811   +/-   ##
=======================================
  Coverage   69.55%   69.55%           
=======================================
  Files           7        7           
  Lines        1248     1248           
  Branches       53       53           
=======================================
  Hits          868      868           
  Misses        379      379           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1772d79...80836e3. Read the comment docs.

@nolanmar511
Copy link
Contributor

nolanmar511 commented Apr 5, 2022

This repo includes a Golang integration test (golang file here).

I believe the go linter is used for that test.

@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@amchiclet
Copy link
Contributor

Closing this. The fix is #818.

@amchiclet amchiclet closed this Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants