feat: support restify 8 (#1250)

googleapis · Apr 21, 2020 · f52fa4d · f52fa4d
1 parent 69b4049
commit f52fa4d
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 3 deletions.
diff --git a/.readme-partials.yaml b/.readme-partials.yaml
@@ -53,7 +53,7 @@ body: |-
     * [gRPC](https://www.npmjs.com/package/grpc) server (version ^1.1)
     * [hapi](https://www.npmjs.com/package/hapi) (versions 8 - 19)
     * [koa](https://www.npmjs.com/package/koa) (version 1 - 2)
-    * [restify](https://www.npmjs.com/package/restify) (versions 3 - 7)
+    * [restify](https://www.npmjs.com/package/restify) (versions 3 - 8)
 
     The agent will also automatically trace RPCs from the following modules:
     * Outbound HTTP requests through `http`, `https`, and `http2` core modules

diff --git a/README.md b/README.md
@@ -104,7 +104,7 @@ The trace agent can do automatic tracing of the following web frameworks:
 * [gRPC](https://www.npmjs.com/package/grpc) server (version ^1.1)
 * [hapi](https://www.npmjs.com/package/hapi) (versions 8 - 19)
 * [koa](https://www.npmjs.com/package/koa) (version 1 - 2)
-* [restify](https://www.npmjs.com/package/restify) (versions 3 - 7)
+* [restify](https://www.npmjs.com/package/restify) (versions 3 - 8)
 
 The agent will also automatically trace RPCs from the following modules:
 * Outbound HTTP requests through `http`, `https`, and `http2` core modules

diff --git a/src/plugins/plugin-restify.ts b/src/plugins/plugin-restify.ts
@@ -25,7 +25,7 @@ type Response = restify_5.Response;
 type Next = restify_5.Next;
 type CreateServerFn = (options?: restify_5.ServerOptions) => restify_5.Server;
 
-const SUPPORTED_VERSIONS = '<=7.x';
+const SUPPORTED_VERSIONS = '<=8.x';
 
 function unpatchRestify(restify: Restify5) {
   shimmer.unwrap(restify, 'createServer');

diff --git a/test/fixtures/plugin-fixtures.json b/test/fixtures/plugin-fixtures.json
@@ -238,5 +238,10 @@
     "dependencies": {
       "restify": "^7.2.2"
     }
+  },
+  "restify8": {
+    "dependencies": {
+      "restify": "^8.5.1"
+    }
   }
 }
diff --git a/test/test-trace-web-frameworks.ts b/test/test-trace-web-frameworks.ts
@@ -41,6 +41,7 @@ import {
   Restify5,
   Restify6,
   Restify7,
+  Restify8,
 } from './web-frameworks/restify';
 
 // The type of a stack trace object after being parsed from a trace span's stack
@@ -68,6 +69,7 @@ const FRAMEWORKS: WebFrameworkConstructor[] = [
   Restify5,
   Restify6,
   Restify7,
+  Restify8,
 ];
 
 /**

diff --git a/test/web-frameworks/restify.ts b/test/web-frameworks/restify.ts
@@ -91,4 +91,5 @@ export const Restify4 = makeRestifyClass(4);
 export const Restify5 = makeRestifyClass(5);
 export const Restify6 = makeRestifyClass(6);
 export const Restify7 = makeRestifyClass(7);
+export const Restify8 = makeRestifyClass(8);
 // tslint:enable:variable-name