Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Restify Plugin to support Restify versions 9-11 #1488

Closed
6utt3rfly opened this issue Mar 7, 2023 · 1 comment · Fixed by #1489
Closed

Update Restify Plugin to support Restify versions 9-11 #1488

6utt3rfly opened this issue Mar 7, 2023 · 1 comment · Fixed by #1489
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@6utt3rfly
Copy link
Contributor

The existing Restify plugin is defined to only operate up to version 8. It was last updated in Apr 2020 from #1250 . The restify changelog has newer, recent releases:
9.0.0 2022-11-05 (drops node <8)
10.0.0 2022-11-29 (adds support for node 18)
11.0.0 2023-01-17

Is it possible to upgrade the restify plugin version range to enable support for the new versions - especially so that node 18 can be supported with restify and this plugin?
@6utt3rfly 6utt3rfly added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Mar 7, 2023
@product-auto-label product-auto-label bot added the api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. label Mar 7, 2023
@6utt3rfly 6utt3rfly mentioned this issue Mar 7, 2023
Merged
@punya
Copy link
Contributor

punya commented Mar 29, 2023

Hi @6utt3rfly. As the README describes, cloud-trace-nodejs is in maintenance mode. That means we'll continue to patch security vulnerabilities, but we won't work on new features (including supporting new major versions of libraries).

We will, however, consider merging contributed PRs. I see that you've already created #1489 - please take a look at the test failures.

gcf-merge-on-green bot pushed a commit that referenced this issue Apr 25, 2023
@6utt3rfly
feat: support restify v9-v11 (#1489)
746f30c 
Fixes #1488

(see also #1250 for reference)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support restify v9-v11
2 participants
@punya @6utt3rfly