Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Extract and propagate B3 headers #949

Closed
majelbstoat opened this issue Jan 8, 2019 · 1 comment · Fixed by #1029
Closed

Feature request: Extract and propagate B3 headers #949

majelbstoat opened this issue Jan 8, 2019 · 1 comment · Fixed by #1029
Assignees
@kjin
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. priority: p2 Moderately-important priority. Fix may not be included in next release. semver: minor A new feature was added. No breaking changes. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@majelbstoat
Copy link

Istio supports distributed tracing on an ingress into a cluster, and between services.

To do this, it propagates a standard set of B3 headers (originally defined for Zipkin, I think?)

x-request-id
x-b3-traceid
x-b3-spanid
x-b3-parentspanid
x-b3-sampled
x-b3-flags
x-ot-span-context

It would be great if the server side portions of this tracer recognised and propagated the information from that source. opencensus-node apparently supports this, though it is itself in very early alpha, and has no GRPC support.

I can share simple istio config that defines this behaviour, if it's helpful.
@majelbstoat majelbstoat changed the title Feature request: Extract and propagate B3 Feature request: Extract and propagate B3 headers Jan 8, 2019
@kjin kjin self-assigned this Jan 9, 2019
@kjin kjin added semver: minor A new feature was added. No breaking changes. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. status: investigating The issue is under investigation, which is determined to be non-trivial. labels Jan 9, 2019
@kjin kjin mentioned this issue Jan 10, 2019
Closed
@ofrobots
Copy link
Contributor

Marking this blocked because #950 is blocked.

@ofrobots ofrobots added the status: blocked Resolving the issue is dependent on other work. label Feb 13, 2019
@kjin kjin removed status: blocked Resolving the issue is dependent on other work. status: investigating The issue is under investigation, which is determined to be non-trivial. labels May 13, 2019
@kjin kjin mentioned this issue May 17, 2019
Merged
@google-cloud-label-sync google-cloud-label-sync bot added the api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kjin kjin

Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. priority: p2 Moderately-important priority. Fix may not be included in next release. semver: minor A new feature was added. No breaking changes. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
3 participants
@ofrobots @majelbstoat @kjin