-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow users to specify a propagation mechanism #950
Conversation
3757724
to
bbaeef2
Compare
Blocked by: census-instrumentation/opencensus-node#340 |
@kjin census-instrumentation/opencensus-node#340 is done. Is this still blocked? |
It'll be unblocked when 0.0.10 is released. In other words, now blocked by Milestone #2 |
@kjin 0.0.10 has been released. Is this still blocked? |
@emillg Thanks for the reminder. I'll move this forward shortly |
I'm going to take a different approach on this... will leave the issue open so it won't get dropped. |
Fixes #949
This feature allows users to supply a
Propagation
(or an absolute path to a file that exports that interface) to specify how trace context headers are injected and extracted from HTTP requests. It also replaces the built-in propagation mechanism with that of@opencensus/propagation-stackdriver
, which has the same behavior.Some notes:
StackdriverTracer
object doesn't have the same interface as the input object, the latter of which is modeled on OpenCensus while the former is just something I deemed to be more suitable for this module. Particularly of note is that OpenCensus treats all span IDs as length-16 hex strings, while we use decimal integer strings.Propagation
object because of the above reasons. I'm open to discussion on this.