Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow users to specify a propagation mechanism #950

Closed
wants to merge 3 commits into from

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Jan 10, 2019

Fixes #949

This feature allows users to supply a Propagation (or an absolute path to a file that exports that interface) to specify how trace context headers are injected and extracted from HTTP requests. It also replaces the built-in propagation mechanism with that of @opencensus/propagation-stackdriver, which has the same behavior.

Some notes:

  • Some OpenCensus propagation libraries either don't export a consistent interface or have implementation bugs, so they won't work out-of-the-box as of yet.
  • The propagation object exposed through the StackdriverTracer object doesn't have the same interface as the input object, the latter of which is modeled on OpenCensus while the former is just something I deemed to be more suitable for this module. Particularly of note is that OpenCensus treats all span IDs as length-16 hex strings, while we use decimal integer strings.
  • It may be better not to accept an OpenCensus Propagation object because of the above reasons. I'm open to discussion on this.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2019
@kjin kjin force-pushed the prop-b3 branch 4 times, most recently from 3757724 to bbaeef2 Compare January 10, 2019 22:31
@kjin kjin changed the title [wip] feat: allow users to specify a propagation mechanism feat: allow users to specify a propagation mechanism Jan 10, 2019
@kjin kjin requested a review from a team January 10, 2019 22:46
@kjin kjin removed the request for review from a team February 6, 2019 01:00
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 7, 2019
@kjin
Copy link
Contributor Author

kjin commented Feb 12, 2019

Blocked by: census-instrumentation/opencensus-node#340

@kjin kjin removed the 🚨 This issue needs some love. label Feb 12, 2019
@ofrobots ofrobots added the status: blocked Resolving the issue is dependent on other work. label Feb 12, 2019
@ofrobots
Copy link
Contributor

@kjin census-instrumentation/opencensus-node#340 is done. Is this still blocked?

@kjin
Copy link
Contributor Author

kjin commented Mar 25, 2019

It'll be unblocked when 0.0.10 is released. In other words, now blocked by Milestone #2

@emillg
Copy link

emillg commented May 5, 2019

@kjin 0.0.10 has been released. Is this still blocked?

@kjin kjin removed the status: blocked Resolving the issue is dependent on other work. label May 6, 2019
@kjin
Copy link
Contributor Author

kjin commented May 6, 2019

@emillg Thanks for the reminder. I'll move this forward shortly

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 6, 2019
@kjin
Copy link
Contributor Author

kjin commented May 13, 2019

I'm going to take a different approach on this... will leave the issue open so it won't get dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Extract and propagate B3 headers
5 participants