-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix code coverage, drop ncp #1013
Conversation
|
This comment has been minimized.
This comment has been minimized.
@ofrobots ah, thanks for the reminder. |
Codecov Report
@@ Coverage Diff @@
## master #1013 +/- ##
=========================================
Coverage ? 91.83%
=========================================
Files ? 107
Lines ? 6380
Branches ? 485
=========================================
Hits ? 5859
Misses ? 382
Partials ? 139 Continue to review full report at Codecov.
|
c9b9ea6
to
251b036
Compare
For posterity, what are the problems that |
The repo and module seem unmaintained, so I don't have hope that this will be fixed. |
ncp
causes issues with running scripts locally. It hasn't been updated in 4 years, so I'm dropping it favor ofjustcp -r
cpy
.coverage
butcodecov
appears to expect these files to exist in.coverage
.--all
as it slows down CI a ton, enough to cause flakes.