Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test source map support for stack traces #1016

Merged
merged 1 commit into from
May 3, 2019

Conversation

kjin
Copy link
Contributor

@kjin kjin commented May 3, 2019

Tests for #1015

@kjin kjin requested a review from a team May 3, 2019 21:15
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 3, 2019
@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #1016 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
+ Coverage   94.75%   94.81%   +0.05%     
==========================================
  Files          97       97              
  Lines        6182     6207      +25     
  Branches      485      486       +1     
==========================================
+ Hits         5858     5885      +27     
+ Misses        184      183       -1     
+ Partials      140      139       -1
Impacted Files Coverage Δ
test/test-span-data.ts 100% <100%> (ø) ⬆️
test/plugins/common.ts 97.01% <0%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c558455...0b9534b. Read the comment docs.

Copy link
Contributor

@soldair soldair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we check to see if this works when node is run with -r source-map-support/register

@kjin
Copy link
Contributor Author

kjin commented May 3, 2019

@soldair thanks for the heads up, our tests run with it by default. I have verified that it still works without the -r though.

@kjin kjin merged commit 2cbf1c2 into googleapis:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants