Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build!: update library to use Node 12 #1442

Merged
merged 9 commits into from
May 24, 2022
Merged

build!: update library to use Node 12 #1442

merged 9 commits into from
May 24, 2022

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented May 20, 2022

Migrate library to Node 12

@sofisl sofisl requested review from a team as code owners May 20, 2022 21:04
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 20, 2022
@generated-files-bot
Copy link

generated-files-bot bot commented May 20, 2022 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • .kokoro/continuous/node10/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node8/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node8/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label bot added the api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. label May 20, 2022
@dnoe
Copy link
Contributor

dnoe commented May 24, 2022

@aabmass Can you take a look? Let me know if you haven't had the approver bit turned on for your user yet and you need me to stamp this.

aabmass
aabmass reviewed May 24, 2022
View reviewed changes
Copy link

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do recommend we make a major version release of this repo after this?

In addition to removing official support for node10, I know some TS major version bumps can produce incompatibilities in the compiled output

.github/workflows/ci.yaml Show resolved Hide resolved
aabmass
aabmass approved these changes May 24, 2022
View reviewed changes
Copy link

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sofisl sofisl merged commit a5fd508 into main May 24, 2022
@sofisl sofisl deleted the migrateToNode12 branch May 24, 2022 22:06
@release-please release-please bot mentioned this pull request May 24, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 30, 2022
@release-please
chore(main): release 6.0.0 (#1443)
0c3967d 
🤖 I have created a release *beep* *boop*
---


## [6.0.0](v5.1.6...v6.0.0) (2022-06-20)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#1442)

### Bug Fixes

* **deps:** update dependency gcp-metadata to v5 ([#1446](#1446)) ([2f264d0](2f264d0))


### Build System

* update library to use Node 12 ([#1442](#1442)) ([a5fd508](a5fd508))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request Jun 30, 2022
Merged
@WontonSam WontonSam mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass aabmass approved these changes

Assignees
No one assigned
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sofisl @dnoe @aabmass