doc: update broken references to source files #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ofrobots
approved these changes
Feb 2, 2018
doc/trace-api.md
Outdated
| @@ -80,7 +80,7 @@ It is highly recommended for plugins to set this header field in responses, _if_ | |||
| * Returns `string` | |||
| * Returns a string that should be set in the response headers in a traced request. If incomingTraceContext is falsy (indicating that the incoming request didn't have a trace context), this function returns an empty string. | |||
|
|
|||
| This function is usually called from within the function passed to `runInRootSpan`. See any of the built-in plugins ([express](../src/plugins/plugin-express.js#L42)) for an example. Note that the value for `isTraced` is based on the value of the root span - if a root span was created, that means that this request is being traced. | |||
| This function is usually called from within the function passed to `runInRootSpan`. See any of the built-in plugins ([express](https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/blob/84bf9cd56fadf63ec3d341aac4cf79410c815d0d/src/plugins/plugin-express.ts#L42)) for an example. Note that the value for `isTraced` is based on the value of the root span - if a root span was created, that means that this request is being traced. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #663 +/- ##
==========================================
- Coverage 90.66% 89.95% -0.72%
==========================================
Files 30 30
Lines 1403 1403
Branches 288 288
==========================================
- Hits 1272 1262 -10
- Misses 54 57 +3
- Partials 77 84 +7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #662