test: fixup issue stemming from testing http2 on node 9.9 #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jinwoo
approved these changes
Mar 23, 2018
| @@ -219,6 +219,8 @@ describe('test-trace-http2', () => { | |||
| server.on( | |||
| 'stream', | |||
| (s: http2.ServerHttp2Stream&({rstWithInternalError: () => void})) => { | |||
| // In Node 9.9+, the error handler is not added by default. | |||
| s.on('error', () => {}); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #699 +/- ##
==========================================
- Coverage 90.15% 90.08% -0.08%
==========================================
Files 29 29
Lines 1422 1422
Branches 287 287
==========================================
- Hits 1282 1281 -1
Misses 57 57
- Partials 83 84 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.