[Storage] Fix Post Policy Conformance Test Design #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amanda-tarafa while reviewing your PR I noticed I mismatched domain and hostname for BucketBoundDomain versus BucketBoundHostname. This PR fixes this inconsistency. |
mengxian-li
approved these changes
Mar 5, 2020
jkwlui
approved these changes
Mar 5, 2020
BenWhitehead
added a commit
to googleapis/java-conformance-tests
that referenced
this pull request
Mar 10, 2020
…3c8 (#89) googleapis/conformance-tests@a3f959e [Storage] Fix Post Policy Conformance Test Design ([#25](googleapis/conformance-tests#25)) googleapis/conformance-tests@5072876 fix newline missing Full diff: googleapis/conformance-tests@4fa0699...a3f959e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing conformance test design with @JesseLovelace, @quartzmo and @jdpedrie, I updated the conformance test design to be more align with the expected surface design.
Conditions are still a slightly difference because of proto definition limitations.
Please let me know if you'd like to see something slightly different here.