Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(storage): change expiration type to int for signingV4Tests #28

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

IlyaFaer
Copy link

@IlyaFaer IlyaFaer commented Apr 3, 2020

See the comment for context.

@IlyaFaer IlyaFaer requested review from frankyn and jkwlui April 3, 2020 10:22
@IlyaFaer IlyaFaer marked this pull request as ready for review April 3, 2020 10:22
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proto type is still the same, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants