-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add deprecation warning for python 3.7 #1743
Closed
+282
−0
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -2,6 +2,9 @@ | |||||
|
||||||
{% block content %} | ||||||
|
||||||
import sys | ||||||
import warnings | ||||||
|
||||||
{% set package_path = api.naming.module_namespace|join('.') + "." + api.naming.versioned_module_name %} | ||||||
from {{package_path}} import gapic_version as package_version | ||||||
|
||||||
|
@@ -36,6 +39,26 @@ from .types.{{ proto.module_name }} import {{ enum.name }} | |||||
{% endfor %} | ||||||
{% endfor %} | ||||||
|
||||||
|
||||||
class Python37DeprecationWarning(DeprecationWarning): | ||||||
""" | ||||||
Deprecation warning raised when Python 3.7 runtime is detected. | ||||||
Python 3.7 support will be dropped after January 1, 2024. See | ||||||
https://cloud.google.com/python/docs/python37-sunset/ for more information. | ||||||
""" | ||||||
pass | ||||||
|
||||||
# Checks if the current runtime is Python 3.7. | ||||||
if sys.version_info.major == 3 and sys.version_info.minor == 7: | ||||||
message = ( | ||||||
"After January 1, 2024, new releases of this client library will drop support " | ||||||
"for Python 3.7. More details about Python 3.7 support for Client Libraries " | ||||||
"can be found at https://cloud.google.com/python/docs/python37-sunset/" | ||||||
) | ||||||
# print only the first occurrence of Python37DeprecationWarning, regardless of location | ||||||
warnings.simplefilter('once', Python37DeprecationWarning) | ||||||
Comment on lines
+58
to
+59
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
This code should be removed. See googleapis/google-auth-library-python#1427 |
||||||
warnings.warn(message, Python37DeprecationWarning) | ||||||
|
||||||
{# Define __all__. | ||||||
This requires the full set of imported names, so we iterate over | ||||||
them again. | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code should be removed. See googleapis/google-auth-library-python#1427