Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add client debug logging support for async gRPC #2291

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Dec 10, 2024

Fixes #2289 🦕

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Dec 10, 2024
@ohmayr ohmayr changed the title Add debug logging for async grpc feat: add client debug logging support for async gRPC Dec 10, 2024
@ohmayr ohmayr force-pushed the add-debug-logging-for-async-grpc branch from bacb352 to 99f2dbf Compare December 11, 2024 20:57
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Dec 11, 2024
@ohmayr ohmayr force-pushed the add-debug-logging-for-async-grpc branch from c19576f to a9e6b7f Compare December 11, 2024 21:23
@ohmayr ohmayr marked this pull request as ready for review December 11, 2024 21:57
@ohmayr ohmayr requested a review from a team as a code owner December 11, 2024 21:57
Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please consider the renaming in my comment for clarity.

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Dec 11, 2024
@ohmayr ohmayr merged commit f45935a into main Dec 11, 2024
125 checks passed
@ohmayr ohmayr deleted the add-debug-logging-for-async-grpc branch December 11, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[logging] add client logging support for gRPC streaming RPCs
3 participants