Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update setup.py with updated version of googleapis-common-protos #2323

Closed
wants to merge 1 commit into from

Conversation

gkevinzheng
Copy link
Contributor

The unit tests I have for selective GAPIC are only able to pass with this setup.py change. This is because each invocation of nox -s unit installs the GAPIC generator in a virtualenv via pip install -e ., which uses the dependencies listed under setup.py.

@gkevinzheng gkevinzheng requested a review from a team as a code owner February 6, 2025 20:56
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Feb 6, 2025
@gkevinzheng
Copy link
Contributor Author

Linking this to #2322 as an additional TODO item once a formal release of googleapis-common-protos version 1.67.0 is out.

@gkevinzheng gkevinzheng closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants