Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [diregapic]missing errors.proto #877

Closed
wants to merge 5 commits into from
Closed

fix: [diregapic]missing errors.proto #877

wants to merge 5 commits into from

Conversation

summer-ji-eng
Copy link
Collaborator

@summer-ji-eng summer-ji-eng commented May 19, 2021

googleads protos are different than most other apis.
It has multiple packages, like

package google.ads.googleads.v7.services;
package google.ads.googleads.v7.errors;

And errors.proto has no service.

Fix: we should allow package'name which has no service differ from service package name.

Local Test: generate googleads

$ bazel build //google/ads/googleads/v7:googleads-nodejs
$ cd .../bazel-bin/google/ads/googleads/v7
$ tar -xf googleads-nodejs.tar.gz
$ grep errors.proto googleads-nodejs/src/v7/*json | wc -l

Results: 126

@summer-ji-eng summer-ji-eng added the draft Do Not Review label May 19, 2021
@summer-ji-eng summer-ji-eng requested a review from a team as a code owner May 19, 2021 20:39
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 19, 2021
@summer-ji-eng
Copy link
Collaborator Author

duplicate with #878

@summer-ji-eng summer-ji-eng deleted the fix_ads branch May 20, 2021 18:29
@summer-ji-eng summer-ji-eng requested review from alexander-fenster and removed request for alexander-fenster May 20, 2021 18:30
@summer-ji-eng summer-ji-eng changed the title fix: missing errors.proto fix: [diregapic]missing errors.proto Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. draft Do Not Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant