This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Make java lowerCamel methos naming match protobuf java stubs out…
…put methods naming. (#3265) Specifically, before this fix, for a field named `one_two3four` protobuf was generating java method named `setOneTwo3Four()`, while gapic generator was assuming it to be `setOneTwo3four()`. This change is applied in the most limited scope (only for java methods naming, because this logic is applied only for methods naming in protobuf). This should be a relatively safe change because protobuf in general does not let fields to differ only by the underscore characters `_`. I.e. one message cannot have two fields one named `one_two` and the other one `onetwo` or `oneTwo`. This restriction greatly reduces number of possible `snake_case` `camelCase` conversion combinations.
- Loading branch information
1 parent
1485371
commit 4d1eef9
Showing
3 changed files
with
31 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters