-
Notifications
You must be signed in to change notification settings - Fork 129
Add exception testing to Python #1141
Add exception testing to Python #1141
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1141 +/- ##
============================================
+ Coverage 86.04% 86.04% +<.01%
- Complexity 3621 3623 +2
============================================
Files 364 364
Lines 14278 14283 +5
Branches 1597 1597
============================================
+ Hits 12285 12290 +5
Misses 1559 1559
Partials 434 434
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But get another +1 before merge.
# Mock exception response | ||
grpc_stub.CreateShelf.side_effect = CustomException() | ||
|
||
self.assertRaises(errors.GaxError, client.create_shelf, shelf) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
LGTM |
No description provided.