Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Add exception testing to Python #1141

Merged
merged 1 commit into from
Mar 29, 2017

Conversation

evaogbe
Copy link
Contributor

@evaogbe evaogbe commented Mar 28, 2017

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #1141 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1141      +/-   ##
============================================
+ Coverage     86.04%   86.04%   +<.01%     
- Complexity     3621     3623       +2     
============================================
  Files           364      364              
  Lines         14278    14283       +5     
  Branches       1597     1597              
============================================
+ Hits          12285    12290       +5     
  Misses         1559     1559              
  Partials        434      434
Impacted Files Coverage Δ Complexity Δ
...api/codegen/transformer/py/PythonSurfaceNamer.java 100% <100%> (ø) 14 <1> (+1) ⬆️
...transformer/py/PythonImportSectionTransformer.java 81.72% <100%> (+0.4%) 22 <2> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d3c736...8c65896. Read the comment docs.

Copy link
Contributor

@lukesneeringer lukesneeringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But get another +1 before merge.

# Mock exception response
grpc_stub.CreateShelf.side_effect = CustomException()

self.assertRaises(errors.GaxError, client.create_shelf, shelf)

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@shinfan
Copy link
Contributor

shinfan commented Mar 28, 2017

LGTM

@lukesneeringer lukesneeringer merged commit b08d618 into googleapis:master Mar 29, 2017
@evaogbe evaogbe deleted the python-test-exception branch December 11, 2017 21:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants