Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

[gapic-generator] fix: fix errorprone bazel errors #3250

Merged
merged 3 commits into from
Jul 14, 2020
Merged

Conversation

miraleung
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2020
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please reformat the code (bazel run //:google_java_format or ./gradlew googleJavaFormat). This is why the CI is failing.

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #3250 into master will decrease coverage by 0.00%.
The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3250      +/-   ##
============================================
- Coverage     87.12%   87.11%   -0.01%     
- Complexity     6076     6078       +2     
============================================
  Files           494      494              
  Lines         24052    24058       +6     
  Branches       2613     2613              
============================================
+ Hits          20955    20958       +3     
- Misses         2234     2238       +4     
+ Partials        863      862       -1     
Impacted Files Coverage Δ Complexity Δ
...a/com/google/api/codegen/config/DiscoApiModel.java 76.66% <0.00%> (-2.65%) 9.00 <0.00> (ø)
...google/api/codegen/config/DiscoInterfaceModel.java 57.14% <0.00%> (-2.86%) 6.00 <0.00> (ø)
...a/com/google/api/codegen/config/ProtoApiModel.java 92.30% <0.00%> (-2.43%) 18.00 <0.00> (ø)
...google/api/codegen/config/ProtoInterfaceModel.java 85.71% <0.00%> (-3.18%) 12.00 <0.00> (ø)
...om/google/api/codegen/config/ProtoMethodModel.java 88.23% <0.00%> (-1.32%) 35.00 <0.00> (ø)
...om/google/api/codegen/gapic/ProtocGapicWriter.java 69.23% <ø> (+2.56%) 5.00 <0.00> (ø)
...oogle/api/codegen/config/DiscoveryMethodModel.java 85.18% <100.00%> (+0.13%) 48.00 <1.00> (+1.00)
...a/com/google/api/codegen/util/MultiYamlReader.java 64.70% <100.00%> (ø) 5.00 <0.00> (ø)
...main/java/com/google/api/codegen/util/Scanner.java 98.79% <100.00%> (+0.01%) 37.00 <0.00> (ø)
.../java/com/google/api/codegen/discovery/Schema.java 84.84% <0.00%> (+0.50%) 43.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 965504d...04ee8d4. Read the comment docs.

@miraleung miraleung merged commit f1381f9 into master Jul 14, 2020
@miraleung miraleung deleted the fix/bazel_build branch July 14, 2020 21:39
@release-please release-please bot mentioned this pull request Jul 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants