This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
feat: switch PHP GAPICs to using default scopes #3306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #3306 +/- ##
=========================================
Coverage 87.13% 87.13%
Complexity 6115 6115
=========================================
Files 495 495
Lines 24159 24159
Branches 2634 2634
=========================================
Hits 21051 21051
Misses 2242 2242
Partials 866 866 Continue to review full report at Codecov.
|
miraleung
approved these changes
Nov 12, 2020
|
+Chris as FYI for the PHP microgenerator. |
dwsupplee
approved these changes
Nov 12, 2020
jdpedrie
approved these changes
Nov 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will activate Self-Signed JWTs for all GAPIC PHP Libraries.
NodeJS has moved to using Self-Signed JWTs for all of their GAPICs without any issues. We feel we can release this for all our GAPIC clients.
PHP Self-Signed JWTs have been tested using the integration tests in php-docs-samples for the following GAPIC clients: