This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
feat: add page streaming for php #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #3318 +/- ##
============================================
- Coverage 87.14% 87.13% -0.01%
Complexity 6120 6120
============================================
Files 495 495
Lines 24172 24173 +1
Branches 2637 2638 +1
============================================
Hits 21064 21064
Misses 2242 2242
- Partials 866 867 +1
Continue to review full report at Codecov.
|
vchudnov-g
reviewed
Dec 10, 2020
| pageSizeField = methodModel.getInputField(pagingParams.getNameForMaxResults()); | ||
| } else if (language == TargetLanguage.PHP) { | ||
| FieldModel resourcesField = ProtoPageStreamingTransformer.getResourcesField(methodModel); | ||
| if (resourcesField != null && !resourcesField.isMap()) { |
There was a problem hiding this comment.
Do we not need this in Java because Java is handling map responses?
There was a problem hiding this comment.
That is my understanding, yes!
bshaffer
force-pushed
the
add-page-streaming-for-php
branch
from
95b14cf
to
9a9ff20
Compare
vam-google
reviewed
Dec 23, 2020
…pic-generator into add-page-streaming-for-php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality now works for MapFields!